Re: [PATCH 0/3] idle, Honor Hardware Disabled States

From: Len Brown
Date: Thu Mar 24 2016 - 17:54:13 EST


On Wed, Mar 23, 2016 at 7:50 PM, Prarit Bhargava <prarit@xxxxxxxxxx> wrote:
>
>
> On 03/23/2016 04:05 PM, Len Brown wrote:
>> This patch assumes that if a package state is disabled,
>> the corresponding core state must be disabled.
>> That assumption is false.
>> Indeed, that is a very popular and useful configuration.
>>
>> But even if that were not the case, this software is not necessary,
>> since the hardware handles demotion "c-state clipping" automatically.
>>
>> Yes, there is a case where a certain version of a certain processor
>> has broken demotion, but this isn't the right fix for that.
>> The right fix for that is here:
>>
>> https://bugzilla.kernel.org/show_bug.cgi?id=109081
>
> Len, should I rebase on top of this? Would that work for you?


I guess I wasn't clear.
I don't see the benefit of your patch.
Please explain it to me.

thanks,
-Len