Re: [PATCH 0/3] nohz: Convert tick dependency mask to atomic_t

From: Ingo Molnar
Date: Fri Mar 25 2016 - 04:49:01 EST



* Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:

> As per Linus suggestion, lets convert the tick dependency mask to
> atomic_t. Introduce atomic_fetch_or() and confine fetch_or() back to
> scheduler guts.
>
> git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
> timers/nohz
>
> HEAD: 7b7e5da5733f58668181077ec394a718e08c392c
>
> Thanks,
> Frederic
> ---
>
> Frederic Weisbecker (3):
> atomic: Introduce atomic_fetch_or
> nohz: Convert tick dependency mask to atomic_t
> Revert "atomic: Export fetch_or()"
>
>
> include/linux/atomic.h | 34 +++++++++++++--------------
> include/linux/sched.h | 4 ++--
> kernel/sched/core.c | 18 ++++++++++++++
> kernel/time/tick-sched.c | 61 ++++++++++++++++++++++++------------------------
> kernel/time/tick-sched.h | 2 +-
> 5 files changed, 68 insertions(+), 51 deletions(-)

Could you please also convert the sched/core.c usage, so that we can get rid of
the private fetch_or() definition? Please also double check that it does not
result in worse code generation.

Thanks,

Ingo