Re: [PATCH] regmap: mmio: Fix value endianness selection

From: Mark Brown
Date: Fri Mar 25 2016 - 07:25:17 EST

On Wed, Mar 23, 2016 at 03:20:46PM +0100, Alexander Stein wrote:

> The difference in those drivers is that syscon manually sets
> config.val_format_endian before calling regmap_init_mmio.
> spi-fsl-dspi does not. I guess this driver relies on this configuration being
> done in regmap_get_val_endian. But this is never reached because after setting
Does this IP exist in configurations where it is anything other than big
endian? If not then this probably shouldn't be in DT.

> map->reg_read this code is skipped due to "goto skip_format_initialization;"
> IMHO a call to regmap_get_val_endian should be added to
> regmap_mmio_gen_context.

That sounds reasonable.

Attachment: signature.asc
Description: PGP signature