Re: [PATCH] Revert "regulator: core: Add support for active-discharge configuration"

From: Vladimir Zapolskiy
Date: Fri Mar 25 2016 - 13:06:30 EST


On 25.03.2016 17:45, Mark Brown wrote:
> On Fri, Mar 25, 2016 at 04:52:32PM +0200, Vladimir Zapolskiy wrote:
>> On 25.03.2016 13:10, Mark Brown wrote:
>>> Please submit patches using subject lines reflecting the style for the
>>> subsystem. This makes it easier for people to identify relevant
>>> patches.
>> Okay, submitting of reverted patches is different I believe:
> Nope, they're patches like other patches. A big part of what the
> subject line does is help people work out what they need to look at,
> something that doesn't pattern match doesn't fulfil that need.

regarding pattern matching just remove ^ from the regexp and people
be aware of this "regulator: core" change.

I understand that the reverted commit is a maintainer's fault and by
renaming the subject you may hide it, so talking about people needs
please let them know that the change _reverts_ another commit.

I can not add Fixes: tag, because the change does not fix a commit, and
there is no Reverts: tag due to its obvious redundancy.

Please look at 1 hour old 1701f680407c ("Revert "ppdev: use new parport
device model" ") --- that's IMHO the proper way to create and apply

And I disagree with the modified subject and commit message done by you
and without a notice mentioning this your change in the commit message.

With best wishes,