Re: [PATCH v2] netpoll: Fix extra refcount release in netpoll_cleanup()

From: David Miller
Date: Fri Mar 25 2016 - 15:16:53 EST

From: Bjorn Helgaas <helgaas@xxxxxxxxxx>
Date: Fri, 25 Mar 2016 11:46:39 -0500

> You're right, there is an issue here. I reproduced a problem with a
> bond device. bond_netpoll_setup() calls __netpoll_setup() directly
> (not netpoll_setup()). I'll debug it more; just wanted to let you
> know there *is* a problem with this patch.

I bet that's why the assignment to np->dev and the reference counting
were separated in the first place :-/

Indeed, commit 30fdd8a082a00126a6feec994e43e8dc12f5bccb:

commit 30fdd8a082a00126a6feec994e43e8dc12f5bccb
Author: Jiri Pirko <jiri@xxxxxxxxxxx>
Date: Tue Jul 17 05:22:35 2012 +0000

netpoll: move np->dev and np->dev_name init into __netpoll_setup()

Signed-off-by: Jiri Pirko <jiri@xxxxxxxxxxx>
Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>