Re: [RFC PATCH v1 1/9] selftest: sync: basic tests for sw_sync framework

[Emil Velikov]

Hi Emilio,

On 9 March 2016 at 15:28, Emilio LÃpez <emilio.lopez@xxxxxxxxxxxxxxx> wrote:
> These tests are based on the libsync test suite from Android.
> This commit lays the ground for future tests, as well as includes
> tests for a variety of basic allocation commands.
>
> Signed-off-by: Gustavo Padovan <gustavo.padovan@xxxxxxxxxxxxxxx>
> Signed-off-by: Emilio LÃpez <emilio.lopez@xxxxxxxxxxxxxxx>
> ---
>

>  tools/testing/selftests/sync/sync.h       | 119 ++++++++++++++++++
Admittedly I know nothing about the kernel selftests although copying
the UAPI header, seems to defeat the purpose of this exercise.
Shouldn't one reuse the existing header ? It would even cause issues
as the interface gets updated (iirc Gustavo changed the ioctl numbers
and/or header name with latter series).

Regards,
Emil