Re: [PATCH] ARM: dts: AM572x-IDK Initial Support

[Nishanth Menon]

On 03/25/2016 10:03 AM, Rob Herring wrote:
> On Thu, Mar 24, 2016 at 05:30:44PM -0500, Nishanth Menon wrote:
>> From: Schuyler Patton <spatton@xxxxxx>
[...]

>> +- AM5728 IDK
>> +  compatible = "ti,am5728-idk", "ti,am5728", "ti,dra742", "ti,dra74", "ti,dra7"
> 
> Okay, but I think the TI folks have gone a bit crazy with all these 
> compatible strings...
> 

Sadly yes :( too many paper spins and trying to maintain requirements
of exact match than wild cards is starting to look crazier over time :(

>> diff --git a/arch/arm/boot/dts/am572x-idk.dts b/arch/arm/boot/dts/am572x-idk.dts
>> new file mode 100644
>> index 000000000000..bb51f6de7b45
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/am572x-idk.dts
>> @@ -0,0 +1,85 @@
[...]

>> +	leds {
>> +		compatible = "gpio-leds";
>> +		led@0 {
> 
> Unit-address without reg is going to start warning in dtc. Use something 
> like "cpu0-led" instead.
> 
Fixed. Thanks. Updated version posted
https://patchwork.kernel.org/patch/8679861/

-- 
Regards,
Nishanth Menon