Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity
From: Tim Harvey
Date: Mon Mar 28 2016 - 15:59:55 EST
On Sun, Mar 27, 2016 at 5:26 PM, Fabio Estevam <festevam@xxxxxxxxx> wrote:
> On Sun, Mar 27, 2016 at 11:44 AM, Fabio Estevam <festevam@xxxxxxxxx> wrote:
>> Good catch!
>> Reviewed-by: Fabio Estevam <fabio.estevam@xxxxxxx>
>> I will fix imx6q-sabresd.dtsi when this patch gets applied.
> After thinking more about it, I think the correct fix is to revert
> 5c5fb40de8f143 ("PCI: imx6: Add support for active-low reset GPIO") so
> that we do not break old dtb's.
> Then a new dt property can be added if someone needs gpio active high PCI reset.
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
I would agree with you on this - 5c5fb40de8f143 ("PCI: imx6: Add
support for active-low reset GPIO") should be reverted.
I just finished bisecting an issue to this specific patch only to find
out Krzysztof found it a few days ago ;) Thanks Krzysztof.