Re: [PATCH v5 4/6] hwmon: (fam15h_power) Introduce a cpu accumulated power reporting algorithm

From: Borislav Petkov
Date: Tue Mar 29 2016 - 03:26:08 EST

On Tue, Mar 29, 2016 at 11:28:48AM +0800, Huang Rui wrote:
> I checked with HW designer, milliseconds is also a reasonable interval
> of acc power. And I cannot set too long here, because several seconds
> will cause the read function to hang for that period of time.

Exactly this justification should be as a comment in the code above the
setting of the default value.

> So I pick 10ms here, and actually, we can update the interval at
> /etc/sensors3.conf
> chip "fam15h_power-*"
> set power1_average_interval 0.01

I think this text should be in Documentation/hwmon/fam15h_power for
users to know.



ECO tip #101: Trim your mails when you reply.