Re: [PATCH] Staging: comedi: Fix 'unsigned' warning style

[Ian Abbott]

On 27/03/16 18:52, Aniket Sharma wrote:
> This patch fixes the checkpatch.pl warning:
>
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> +       unsigned runflags;
>
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> +struct comedi_device *comedi_dev_get_from_minor(unsigned minor);
>
> Signed-off-by: Aniket Sharma <badbuddha91@xxxxxxxxx>
> ---
>   drivers/staging/comedi/comedidev.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
> index 1158072..dcb6376 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -173,7 +173,7 @@ struct comedi_subdevice {
>
>   	void *lock;
>   	void *busy;
> -	unsigned runflags;
> +	unsigned int runflags;
>   	spinlock_t spin_lock;	/* generic spin-lock for COMEDI and drivers */
>
>   	unsigned int io_bits;
> @@ -566,7 +566,7 @@ struct comedi_device {
>
>   void comedi_event(struct comedi_device *dev, struct comedi_subdevice *s);
>
> -struct comedi_device *comedi_dev_get_from_minor(unsigned minor);
> +struct comedi_device *comedi_dev_get_from_minor(unsigned int minor);
>   int comedi_dev_put(struct comedi_device *dev);
>
>   bool comedi_is_subdevice_running(struct comedi_subdevice *s);

Thanks!

Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx> )=-
-=(                          Web: http://www.mev.co.uk/  )=-