Re: [PATCH] fs/vfs: improve __mnt_is_readonly

[Richard Weinberger]

On Tue, Mar 29, 2016 at 8:35 AM, Yaowei Bai
<baiyaowei@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Sat, Mar 26, 2016 at 12:43:32AM +0000, Al Viro wrote:
>> On Fri, Mar 25, 2016 at 10:01:26AM +0800, Yaowei Bai wrote:
>> > This patch refactors __mnt_is_readonly and makes it return bool to
>> > improve readability due to this particular function only using either
>> > one or zero as its return value.
>>
>> Improve in which way, if I may ask?
>
> A boolean return value can be more matchable with function's name and
> more suitable as this function only returns 0/1.

Please also think of the arguments made on linux-mtd[1].
Hopping from one subsystem to another trying to sneak patches
in is not the best idea... :-)

[1]: http://lists.infradead.org/pipermail/linux-mtd/2016-March/066296.html

-- 
Thanks,
//richard