Re: [ANNOUNCE] util-linux v2.28-rc2

From: Ruediger Meier
Date: Tue Mar 29 2016 - 05:58:51 EST


On Tuesday 29 March 2016, Samuel Thibault wrote:
> Hello,
>
> Karel Zak, on Tue 29 Mar 2016 11:10:12 +0200, wrote:
> > The util-linux release v2.28-rc2 is available at
> >
> > http://ftp.kernel.org/pub/linux/utils/util-linux/v2.28
> >
> > Feedback and bug reports, as always, are welcomed.
>
> The Hurd provides a BSD-compatible interface (thus defines BSD to
> something 1993-ish), but not compatible with more recent BSDs.
> setprogname appeared around 2004 and such. The patch below just
> detects the availability.
>
> Samuel
>
>
> diff --git a/configure.ac b/configure.ac
> index 1519c97..9502d84 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -380,6 +380,7 @@ AC_CHECK_FUNCS([ \
> qsort_r \
> rpmatch \
> scandirat \
> + setprogname \
> setresgid \
> setresuid \
> sched_setattr \
> diff --git a/misc-utils/getopt.c b/misc-utils/getopt.c
> index c4144f6..1efae07 100644
> --- a/misc-utils/getopt.c
> +++ b/misc-utils/getopt.c
> @@ -453,7 +453,7 @@ int main(int argc, char *argv[])
>
> if (name) {
> argv[optind - 1] = name;
> -#if defined (BSD) || defined (__APPLE__)
> +#if (defined (BSD) || defined (__APPLE__)) && defined (HAVE_SETPROGNAME)

Then I would simply use only
#if defined (HAVE_SETPROGNAME)

or, to be 105% sure to avoid any side effects on our "normal" Linux target

#if defined (HAVE_SETPROGNAME) && ! defined __linux__


> setprogname(name);
> #endif
> } else
> --
> To unsubscribe from this list: send the line "unsubscribe util-linux"
> in the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html