Re: [PATCH 06/12] ARM: dts: dragonboard-600c: Add eMMC and SD card support

From: Srinivas Kandagatla
Date: Tue Mar 29 2016 - 11:03:13 EST




On 29/03/16 15:38, Bjorn Andersson wrote:
On Wed 23 Mar 12:47 PDT 2016, Srinivas Kandagatla wrote:

This patch adds eMMC and SD card support with card detect and adding
required regulators.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
---
.../arm/boot/dts/qcom-apq8064-dragonboard-600c.dts | 41 ++++++++++++++++++++++
1 file changed, 41 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-apq8064-dragonboard-600c.dts b/arch/arm/boot/dts/qcom-apq8064-dragonboard-600c.dts
index 0a0bcfe..a977314 100644
--- a/arch/arm/boot/dts/qcom-apq8064-dragonboard-600c.dts
+++ b/arch/arm/boot/dts/qcom-apq8064-dragonboard-600c.dts
@@ -1,4 +1,5 @@
#include "qcom-apq8064-v2.0.dtsi"
+#include <dt-bindings/gpio/gpio.h>

/ {
model = "Qualcomm Technologies, Inc. APQ8064 DragonBoard600c";
@@ -22,6 +23,16 @@
};

soc {
+ pinctrl@800000 {
+ card_detect: card_detect {
+ mux {
+ pins = "gpio26";
+ function = "gpio";
+ bias-disable;
+ };
+ };
+ };
+
rpm@108000 {
regulators {
vdd_l1_l2_l12_l18-supply = <&pm8921_s4>;
@@ -62,6 +73,18 @@
regulator-max-microvolt = <1300000>;
qcom,switch-mode-frequency = <3200000>;
};
+
+ l5 {
+ regulator-min-microvolt = <2750000>;
+ regulator-max-microvolt = <3000000>;
+ bias-pull-down;
+ };
+
+ l6 {
+ regulator-min-microvolt = <2950000>;
+ regulator-max-microvolt = <2950000>;
+ bias-pull-down;
+ };

I would prefer if you folded these into the regulator patch.

OK, I will give it a go and see how it looks.


};
};

@@ -87,5 +110,23 @@
pinctrl-0 = <&gsbi7_uart_2pins>;
};
};
+
+ amba {
+ /* eMMC */
+ sdcc@12400000 {
+ status = "okay";
+ vmmc-supply = <&pm8921_l5>;
+ vqmmc-supply = <&pm8921_s4>;
+ };
+
+ /* External micro SD card */
+ sdcc@12180000 {
+ status = "okay";
+ vmmc-supply = <&pm8921_l6>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&card_detect>;
+ cd-gpios = <&tlmm_pinmux 26 GPIO_ACTIVE_HIGH>;
+ };
+ };

Other than that,


Acked-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>


Thanks for the Ack.
Regards,
Bjorn