Re: [RFC PATCH] acpi: Use a more normal logging style for ACPI_<LEVEL> calls

From: Joe Perches
Date: Tue Mar 29 2016 - 12:12:29 EST


On Tue, 2016-03-29 at 15:34 +0000, Moore, Robert wrote:
> On the other hand, we removed AE_INFO from ACPI_INFO a while back, and
> this may remove the necessity for the double parens.

Does remove the necessity.

I suppose I could look through the ACPICA sources and generate
the same patch in the ACPICA style.

I didn't manage to run the script that does the style
conversion though.

$ git clone git://github.com/acpica/acpica.git
$ cd acpica
$ make
$

now what?

Removing AE_INFO from ACPI_(WARNING|ERROR) (it seems there
are only a few uses without it and those uses seem
equivalent) is doable too.

For instance:

$ git grep -w ACPI_ERROR|grep -v AE_INFO
[]
source/components/utilities/utobject.c:        ACPI_ERROR ((ModuleName, LineNumber,
source/components/utilities/uttrack.c:        ACPI_ERROR ((Module, Line,
source/components/utilities/uttrack.c:        ACPI_ERROR ((Module, Line,
source/components/utilities/uttrack.c:        ACPI_ERROR ((Module, Line,