Re: [PATCH v8 00/10] Multi-instance vTPM proxy driver
From: Jarkko Sakkinen
Date: Tue Mar 29 2016 - 12:24:44 EST
On Sun, Mar 13, 2016 at 06:54:30PM -0400, Stefan Berger wrote:
> The following series of patches implements a multi-instance vTPM
> proxy driver that can dynamically create TPM 'server' and client device
> Using an ioctl on the provided /dev/vtpmx, a client-side vTPM device
> and a server side file descriptor is created. The file descriptor must
> be passed to a TPM emulator. The device driver will initialize the
> emulated TPM using TPM 1.2 or TPM 2 startup commands and it will read
> the command durations from the device in case of a TPM 1.2. The choice
> of emulated TPM device (1.2 or 2) must be provided with a flag in
> the ioctl.
> The driver is based on a recent checkout of James Morris's 'next'
> branch and uses several recently posted patches from Jason and Jarkko.
I don't remember if I said this but up to the IDR patch I merged patches
to next (at the same day you sent this) so for v9 you can only include
top four changes.
> - minor tweaks on the documentation
> - Reordered function calls in the VTPM proxy driver's server side release
> function so that a client holding the 'ops' lock releases it before the
> driver tries to grab the lock when unregistering the device.
> - Adjusted name of driver to tpm_vtpm_proxy from tpm_vtpm. Adjust function
> names, names of structures, and names of constants.
> - Adjusted IOCTL to use magic 0xa1 rather than the completely used 0xa0.
> - Extended driver documentation and added documentation of ioctl.
> - Moved test program to own project (dropped patch 11).
> - Adapted errno's for unsupported flags and ioctls following Jason's
> - Introduced different error codes for unsupported flags and ioctls
> - Added documentation patch
> Jason Gunthorpe (4):
> tpm: Get rid of chip->pdev
> tpm: Get rid of devname
> tpm: Provide strong locking for device removal
> tpm: Split out the devm stuff from tpmm_chip_alloc
> Stefan Berger (6):
> tpm: Get rid of module locking
> tpm: Replace device number bitmap with IDR
> tpm: Introduce TPM_CHIP_FLAG_VIRTUAL
> tpm: Proxy driver for supporting multiple emulated TPMs
> tpm: Initialize TPM and get durations and timeouts
> tpm: Add documentation for the tpm_vtpm device driver
> Documentation/ioctl/ioctl-number.txt | 1 +
> Documentation/tpm/tpm_vtpm_proxy.txt | 71 ++++
> drivers/char/tpm/Kconfig | 10 +
> drivers/char/tpm/Makefile | 1 +
> drivers/char/tpm/tpm-chip.c | 221 ++++++++----
> drivers/char/tpm/tpm-dev.c | 15 +-
> drivers/char/tpm/tpm-interface.c | 50 +--
> drivers/char/tpm/tpm-sysfs.c | 22 +-
> drivers/char/tpm/tpm.h | 30 +-
> drivers/char/tpm/tpm2-cmd.c | 8 +-
> drivers/char/tpm/tpm_atmel.c | 14 +-
> drivers/char/tpm/tpm_eventlog.c | 2 +-
> drivers/char/tpm/tpm_eventlog.h | 2 +-
> drivers/char/tpm/tpm_i2c_atmel.c | 16 +-
> drivers/char/tpm/tpm_i2c_infineon.c | 6 +-
> drivers/char/tpm/tpm_i2c_nuvoton.c | 24 +-
> drivers/char/tpm/tpm_infineon.c | 22 +-
> drivers/char/tpm/tpm_nsc.c | 20 +-
> drivers/char/tpm/tpm_tis.c | 18 +-
> drivers/char/tpm/tpm_vtpm_proxy.c | 649 +++++++++++++++++++++++++++++++++++
> include/uapi/linux/Kbuild | 1 +
> include/uapi/linux/vtpm_proxy.h | 42 +++
> 22 files changed, 1066 insertions(+), 179 deletions(-)
> create mode 100644 Documentation/tpm/tpm_vtpm_proxy.txt
> create mode 100644 drivers/char/tpm/tpm_vtpm_proxy.c
> create mode 100644 include/uapi/linux/vtpm_proxy.h