RE: [PATCH] ACPICA: Remove unnecessary "\n" from an ACPI_INFO boot message

From: Moore, Robert
Date: Tue Mar 29 2016 - 15:10:16 EST


Actually, I did in fact put that there to break up the output after the tables are loaded. Is this a problem?


> -----Original Message-----
> From: Daniel Bristot de Oliveira [mailto:bristot@xxxxxxxxxx]
> Sent: Monday, March 28, 2016 10:59 AM
> To: Moore, Robert; Zheng, Lv; Wysocki, Rafael J; Len Brown
> Cc: linux-acpi@xxxxxxxxxxxxxxx; devel@xxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH] ACPICA: Remove unnecessary "\n" from an ACPI_INFO boot
> message
>
> A "\n" at the end of bellow ACPI_INFO message is causing a blank line in
> the kernel log:
>
> ACPI_INFO(("%u ACPI AML tables successfully acquired and loaded\n",
> tables_loaded));
>
> This patch removes the "\n".
>
> Kernel log before this patch:
> ACPI: Core revision 20160108
> ACPI: 2 ACPI AML tables successfully acquired and loaded
>
> Security Framework initialized
>
> Kernel log after this patch:
> ACPI: Core revision 20160108
> ACPI: 2 ACPI AML tables successfully acquired and loaded
> Security Framework initialized
>
> Signed-off-by: Daniel Bristot de Oliveira <bristot@xxxxxxxxxx>
>
> diff --git a/drivers/acpi/acpica/tbxfload.c
> b/drivers/acpi/acpica/tbxfload.c index 3151968..e435b84 100644
> --- a/drivers/acpi/acpica/tbxfload.c
> +++ b/drivers/acpi/acpica/tbxfload.c
> @@ -240,7 +240,8 @@ acpi_status acpi_tb_load_namespace(void)
> }
>
> if (!tables_failed) {
> - ACPI_INFO(("%u ACPI AML tables successfully acquired and
> loaded\n", tables_loaded));
> + ACPI_INFO(("%u ACPI AML tables successfully acquired and
> loaded",
> + tables_loaded));
> } else {
> ACPI_ERROR((AE_INFO,
> "%u table load failures, %u successful",
> --
> 2.5.0