Re: [PATCH] usb: rework CONFIG_USB_COMMON logic
From: Felipe Balbi
Date: Wed Mar 30 2016 - 06:32:59 EST
Arnd Bergmann <arnd@xxxxxxxx> writes:
> [ text/plain ]
> The phy-am335x driver selects 'USB_COMMON', but all other drivers
> use 'depends on' for that symbol, and it depends on USB || USB_GADGET
> itself, which causes a Kconfig warning:
>
> warning: (AM335X_PHY_USB) selects USB_COMMON which has unmet direct dependencies (USB_SUPPORT && (USB || USB_GADGET))
>
> As suggested by Felipe Balbi, this turns the logic around, and makes
> 'USB_COMMON' selected by everything else that needs it, so we can
> remove the dependencies.
>
> Fixes: 59f042f644c5 ("usb: phy: phy-am335x: bypass first VBUS sensing for host-only mode")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Acked-by: Felipe Balbi <balbi@xxxxxxxxxx>
> Reviewed-by: Peter Chen <peter.chen@xxxxxxx>
> ---
> I seem to have dropped the ball on this one after my initial submission
> when it wasn't clear who should merge the patch.
>
> Please apply to the USB or the USB gadget tree, whoever gets there
> first.
seems like this is one of those "can wait for next merge window" right ?
I'll take it through my tree. No issues.
--
balbi
Attachment:
signature.asc
Description: PGP signature