Re: [PATCH] scripts: coccinelle: remove check to move constants to right

From: Wolfram Sang
Date: Wed Mar 30 2016 - 08:19:47 EST


On Sat, Mar 19, 2016 at 06:43:08PM +0100, Julia Lawall wrote:
> On Sat, 19 Mar 2016, Wolfram Sang wrote:
>
> > The header mentions this check depends on personal taste. I agree.
> > Running coccicheck on patches before I apply them, this SmPL produced
> > enough false positives for me that I'd rather see it removed.
>
> An improvement is coming up, that should be more acceptable. However,
> it's being held up by the need for some bug fixes in Coccinelle. A
> release of Coccinelle is planned for the beginning of April. Perhaps
> it is just as well to just remove this version for now.
>
> Acked-by: Julia Lawall <julia.lawall@xxxxxxx>

Michal, can we have that in v4.6 please? The false positives are
annoying...

Thanks,

Wolfram

Attachment: signature.asc
Description: PGP signature