Re: [RFC PATCH 12/12] IMA: Use the the system trusted keyrings instead of .ima_mok [ver #3]

[David Howells]

Mimi Zohar <zohar@xxxxxxxxxxxxxxxxxx> wrote:

> > +choice
> > +	prompt "Allow keys to be added to the ima keyrings by userspace?"
> > +	depends on IMA_APPRAISE
> > +	depends on INTEGRITY_ASYMMETRIC_KEYS
> > +	default IMA_NO_ADD_TO_IMA_KEYRINGS
> 
> In this patch, the choice should be between checking just the builtin
> trusted keys or both the builtin trusted and secondary keys.

The third option I've added is that you can't add to .ima at all.  You only
get what's included at build time.  You don't want that option?

> if IMA is enabled, I'm not sure what IMA_NO_ADD_TO_IMA_KEYRINGS means.

Oops.  that should be IMA_KEYRINGS_COMPILE_LOAD_ONLY.

"IMA_NO_ADD_TO_IMA_KEYRINGS" seemed to be phrased too clunkily, but the
Kconfig parser warn you about the undefined symbol.

> > +config IMA_KEYRINGS_COMPILE_LOAD_ONLY
> > +	bool "No runtime key addition"
> ...
> This could be useful for namespacing IMA. 

You said you didn't want this option above (to quote: In this patch, the
choice should be between checking just the builtin trusted keys or both the
builtin trusted and secondary keys.)

David