Re: [PATCH] regulator: Fix deadlock during regulator registration
From: Jon Hunter
Date: Wed Mar 30 2016 - 13:41:16 EST
On 30/03/16 18:00, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Wed, Mar 30, 2016 at 05:46:05PM +0100, Jon Hunter wrote:
>
> Please fix your mail client to word wrap within paragraphs at something
> substantially less than 80 columns. Doing this makes your messages much
> easier to read and reply to.
>
>>> Please don't paste entire backlogs into changelogs, they're *enormous*,
>>> mostly noise and obscure any actual content that's in there through
>>> denial of service. If they're useful then include edited subsets that
>>> highlight the relevant sections of the backtrace so your changelog is
>>> more legible.
>
>> Ok, no problem. Are you happy with the patch otherwise? If so, do you
>> want me to resend or do you wish to trim the backlog? I think that
>
> I haven't reviwed it yet.
>
>> this part is interesting ...
>
> I'm really getting nothing at all from this, all it really does is point
> to the call site but that's already much more clearly identified in the
> changelog. We certainly don't need to know which driver called this.
Ok, fine with me. If you are happy with the actual change, feel free to
remove the backlog or I can re-send if you wish.
Jon