Re: [PATCH] elevator: remove second argument in elevator_init()

From: Jens Axboe
Date: Wed Mar 30 2016 - 20:34:41 EST

On 03/30/2016 05:31 PM, Alexey Klimov wrote:
Hi all,

On Wed, Jan 27, 2016 at 9:01 PM, Jeff Moyer <jmoyer@xxxxxxxxxx> wrote:
Alexey Klimov <klimov.linux@xxxxxxxxx> writes:

Last user of elevator_init() with non-NULL name as second argument
that supposed to be s390 dasd driver has gone few releases ago.
Drivers rely on elevator_change(), elevator_switch() and friends
for example. Right now elevator_init() is always called as
elevator_init(q, NULL).

Patch removes passing of second name argument and its usage.

While we're at it fix following if-check after removed lines. We know
that elevator_type e is initialized by NULL and need to check only

Signed-off-by: Alexey Klimov <klimov.linux@xxxxxxxxx>

Reviewed-by: Jeff Moyer <jmoyer@xxxxxxxxxx>

what is the status of this patch? Is it that wrong and are there some
concerns or do I need to resend it?

It looks fine, I'll pick it up for 4.7.

Jens Axboe