Re: [PATCH v1 2/8] block: make 'struct bvec_iter' not depend on CONFIG_BLOCK

[Ming Lei]

On Thu, Mar 31, 2016 at 1:19 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> On Thu, Mar 31, 2016 at 12:17:11AM +0800, Ming Lei wrote:
>> We will use bvec iterator to implement iterate_bvec(): lib/iov_iter.c.
>>
>> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
>> Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxxxxx>
>> ---
>>  include/linux/blk_types.h | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
>> index 86a38ea..fd8527b 100644
>> --- a/include/linux/blk_types.h
>> +++ b/include/linux/blk_types.h
>> @@ -26,8 +26,6 @@ struct bio_vec {
>>       unsigned int    bv_offset;
>>  };
>>
>> -#ifdef CONFIG_BLOCK
>> -
>>  struct bvec_iter {
>>       sector_t                bi_sector;      /* device address in 512 byte
>>                                                  sectors */
>> @@ -39,6 +37,8 @@ struct bvec_iter {
>>                                                  current bvec */
>>  };
>
> I didn't catch this earlier, but shouldn't this also move to
> bvec_iter.h? Or maybe just create a linux/bvec.h for the bvec, bvec_iter
> and bvec iter macros given that those are the types used outside the
> block layer as well.

That way may cause trouble to blk_type.h because it needs bvec_iter,
then looks not good to always include bvec_iter.h into blk_type.h.

Thanks,
Ming