Re: [PATCH v6 1/7][Resend] cpufreq: sched: Helpers to add and remove update_util hooks

From: Peter Zijlstra
Date: Thu Mar 31 2016 - 08:47:42 EST


On Tue, Mar 22, 2016 at 02:46:34AM +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>
> Replace the single helper for adding and removing cpufreq utilization
> update hooks, cpufreq_set_update_util_data(), with a pair of helpers,
> cpufreq_add_update_util_hook() and cpufreq_remove_update_util_hook(),
> and modify the users of cpufreq_set_update_util_data() accordingly.
>
> With the new helpers, the code using them doesn't need to worry
> about the internals of struct update_util_data and in particular
> it doesn't need to worry about populating the func field in it
> properly upfront.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> ---
>
> No changes since v4 (this patch appeared then).
>
> ---
> drivers/cpufreq/cpufreq_governor.c | 76 ++++++++++++++++++-------------------
> drivers/cpufreq/intel_pstate.c | 8 +--
> include/linux/sched.h | 5 +-
> kernel/sched/cpufreq.c | 48 ++++++++++++++++++-----
> 4 files changed, 83 insertions(+), 54 deletions(-)
>

Acked-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>