Re: [PATCH v7 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver

From: Sylwester Nawrocki
Date: Thu Mar 31 2016 - 08:54:45 EST


On 03/31/2016 02:28 PM, Chanwoo Choi wrote:
>> > You should use IS_ERR() instead of IS_ERR_OR_NULL(), since functions
>> > of which the return value is being tested return only ERR_PTR() values.
>> > IS_ERR_OR_NULL() suggest NULL values are possible and then constructs
>> > like
>> > if (IS_ERR_OR_NULL(result))
>> > return PTR_ERR(result);
>> >
>> > are not correct anyway.
>
> OK. I'll use IS_ERR() instead of IS_ERR_OR_NULL()

Thanks, I forgot to mention there is similar issue in patches
5/20 and 6/20.

--
Regards
Sylwester