Re: [PATCH 8/9] drivers/gpio: make gpio-xgene.c explicitly non-modular

From: Linus Walleij
Date: Thu Mar 31 2016 - 09:10:01 EST


On Sun, Mar 27, 2016 at 5:44 PM, Paul Gortmaker
<paul.gortmaker@xxxxxxxxxxxxx> wrote:

> The Kconfig currently controlling compilation of this code is:
>
> drivers/gpio/Kconfig:config GPIO_XGENE
> drivers/gpio/Kconfig: bool "APM X-Gene GPIO controller support"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
>
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
>
> Cc: Feng Kan <fkan@xxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: Alexandre Courbot <gnurou@xxxxxxxxx>
> Cc: linux-gpio@xxxxxxxxxxxxxxx
> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>

Patch applied.

Yours,
Linus Walleij