Re: [PATCH] gpio: pxa: fix legacy non pinctrl aware builds

[Linus Walleij]

On Tue, Mar 29, 2016 at 10:04 AM, Robert Jarzmik <robert.jarzmik@xxxxxxx> wrote:

> In legacy pxa builds, ie. non device-tree and platform-data only builds,
> pinctrl is not yet available. As a consequence, the pinctrl gpio
> direction change function is a stub, returning always success.
>
> In the current state, the gpio driver direction function believes the
> pinctrl direction change was successful, and exits without actually
> changing the gpio direction.
>
> This patch changes the logic :
>  - if the pinctrl direction function fails, gpio direction will report
>    that failure
>  - if the pinctrl direction function succeeds, gpio direction is changed
>    by the gpio driver anyway.
>    This is sub optimal in the pinctrl aware case, as the gpio direction
>    will be changed twice: once by pinctrl function and another time by
>    the gpio direction function.
>
> Yet it should be acceptable in this form, as this is functional for all
> pxa platforms (device-tree and platform-data), and moreover changing a
> gpio direction is very very seldom, usually in machine initialization,
> seldom in drivers probe, and an exception for ac97 reset bug.
>
> Fixes: a770d946371e ("gpio: pxa: add pin control gpio direction and request")
> Reported-by: Guenter Roeck <guenter@xxxxxxxxxxxx>
> Tested-by: Guenter Roeck <guenter@xxxxxxxxxxxx>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@xxxxxxx>

Patch applied for fixes.

Yours,
Linus Walleij