Re: [PATCH v3 12/18] dt-bindings: Add PLX Technology OXNAS pinctrl and gpio bindings
From: Rob Herring
Date: Thu Mar 31 2016 - 09:36:52 EST
On Thu, Mar 31, 2016 at 3:58 AM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Fri, Mar 25, 2016 at 3:48 PM, Rob Herring <robh@xxxxxxxxxx> wrote:
>> On Thu, Mar 24, 2016 at 05:50:09PM +0100, Neil Armstrong wrote:
>>> Add pinctrl and gpio DT bindings for PLX Technology OXNAS SoC Family.
>>> This version supports the ARM926EJ-S based OX810SE SoC with 34 IO pins.
>>> Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
>>> + - plxtech,gpio-bank: Specifies which bank a controller owns.
>> How is this used?
> That is used to give a unique ID number to the bank.
> Hardware often need this to cross-reference pin controllers
> to GPIO banks.
> I should add it as "gpio-bank" to the generic bindings
> instead, several platforms already use this and there is
> no point in having a vendor prefix in front of it.
Okay, now it is clearer. I don't want this documented as a common
property because I don't want to encourage it's use. I only see 2
users currently: ST and PIC32.
Looking at one example, it appears to be redundant already.
nomadik-gpio-chips property already gives you the index. The index of
the phandles is the bank numbering. PIC32 could do the same.