Re: [PATCH 1/4] samples/bpf: Fix build breakage with map_perf_test_user.c

From: Alexei Starovoitov
Date: Thu Mar 31 2016 - 13:44:58 EST


On 3/31/16 4:25 AM, Naveen N. Rao wrote:
Building BPF samples is failing with the below error:

samples/bpf/map_perf_test_user.c: In function âmainâ:
samples/bpf/map_perf_test_user.c:134:9: error: variable ârâ has
initializer but incomplete type
struct rlimit r = {RLIM_INFINITY, RLIM_INFINITY};
^
Fix this by including the necessary header file.

Cc: Alexei Starovoitov <ast@xxxxxx>
Cc: David S. Miller <davem@xxxxxxxxxxxxx>
Cc: Ananth N Mavinakayanahalli <ananth@xxxxxxxxxx>
Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
Signed-off-by: Naveen N. Rao <naveen.n.rao@xxxxxxxxxxxxxxxxxx>
---
samples/bpf/map_perf_test_user.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/samples/bpf/map_perf_test_user.c b/samples/bpf/map_perf_test_user.c
index 95af56e..3147377 100644
--- a/samples/bpf/map_perf_test_user.c
+++ b/samples/bpf/map_perf_test_user.c
@@ -17,6 +17,7 @@
#include <linux/bpf.h>
#include <string.h>
#include <time.h>
+#include <sys/resource.h>
#include "libbpf.h"
#include "bpf_load.h"

It's failing this way on powerpc? Odd.
Such hidden header dependency was always puzzling to me. Anyway:
Acked-by: Alexei Starovoitov <ast@xxxxxxxxxx>

I'm assuming you want this set to go via 'net' tree, so please resubmit
with [PATCH net 1/4] subjects and cc netdev.

Reviewing your other patches...