Re: [PATCH v4 1/4] SROP Mitigation: Architecture independent code for signal cookies

From: Eric W. Biederman
Date: Thu Mar 31 2016 - 18:28:11 EST

Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> writes:

> On Thu, Mar 31, 2016 at 3:25 PM, Eric W. Biederman
> <ebiederm@xxxxxxxxxxxx> wrote:
>> I suspect we want this to be a per-mm attribute rather than a per-thread
>> attribute.
>> Otherwise you are breaking anything that uses a N-M threading model.
>> Which I suspect means that this implementation choice breaks all go
>> programs on linux.
> That sounds like a good point, but wouldn't it make more conceptual
> sense to make it part of "struct sighand_struct" instead?
> That is also shared for threads.

Good point. Given this is a signal handling feature
struct sighand_struct is the natural place to put this.