Re: [PATCH] mm: Refactor find_get_pages() & friends
From: Kent Overstreet
Date: Thu Mar 31 2016 - 22:35:25 EST
On Tue, Mar 29, 2016 at 02:29:11PM -0700, Andrew Morton wrote:
> On Tue, 8 Mar 2016 16:16:43 -0900 Kent Overstreet <kent.overstreet@xxxxxxxxx> wrote:
>
> > Collapse redundant implementations of various gang pagecache lookup - this is
> > also prep work for pagecache iterator work
>
> Patch looks nice. Unfortunately filemap.c has changed rather a lot
> since 4.5. Can you please redo the patch some time?
>
> And a more informative changelog would be appropriate, although it's
> all pretty obvious. I don't know what "pagecache iterator work" is
> and I doubt if many other readers do either, so some illumination there
> wouldn't hurt.
Can do - sending you the pagecache iterator patch too:
Kent Overstreet (2):
mm: Refactor find_get_pages() & friends
mm: Real pagecache iterators
fs/ext4/inode.c | 261 +++++++++++++------------------
include/linux/pagemap.h | 142 +++++++++++++++--
include/linux/pagevec.h | 67 +++++++-
include/linux/radix-tree.h | 49 ++----
mm/filemap.c | 376 ++++++++++-----------------------------------
mm/page-writeback.c | 148 ++++++++----------
mm/swap.c | 33 +---
mm/truncate.c | 259 ++++++++++++-------------------
8 files changed, 546 insertions(+), 789 deletions(-)
--
2.8.0.rc3