Re: [PATCH] perf tools: Fix build errors on tsc functions for archs other than x86

[Arnaldo Carvalho de Melo]

Em Fri, Apr 01, 2016 at 10:13:12AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Apr 01, 2016 at 03:49:32AM +0000, He Kuang escreveu:
> > Build errors on aarch64:
> > 
> >   libperf.a(libperf-in.o): In function `convert_timestamp':
> >   util/jitdump.c:356: undefined reference to `tsc_to_perf_time'
> >   collect2: error: ld returned 1 exit status
> >   Makefile.perf:347: recipe for target 'perf' failed
> >   make[1]: *** [perf] Error 1
> >   Makefile:68: recipe for target 'all' failed
> >   make: *** [all] Error 2
> 
> Got it, my cross-compile environment for aarch64 doesn't build jitdump.c
> because it needs a package I haven't found in ubuntu:
> 
> config/Makefile:416: No libcrypto.h found, disables jitted code injection, please install libssl-devel or libssl-dev
> minimal-ubuntu-x-arm64: Ok
> 
> BTW, He, what environment do you use to build for arm64, is it a cross
> compile one? Yocto?

Adrian, BTW, Ok with this? I'm adding a:

Fixes: d3e58a3b8b3b ("perf jit: Add support for using TSC as a timestamp")

And would appreciate your Acked-by.

Thanks,

- Arnaldo