Re: [PATCH 12/12] mtd: nand: move of_get_nand_xxx() helpers into nand_base.c

[Boris Brezillon]

On Fri, 1 Apr 2016 22:13:43 +0800
kbuild test robot <lkp@xxxxxxxxx> wrote:

> Hi Boris,
> 
> [auto build test WARNING on next-20160401]
> [cannot apply to v4.6-rc1 v4.5-rc7 v4.5-rc6 v4.6-rc1]
> [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Boris-Brezillon/mtd-get-rid-of-of_mtd-c-h-and-of_get_nand_xx/20160401-210220
> reproduce: make htmldocs
> 
> All warnings (new ones prefixed by >>):
> 
> >> drivers/mtd/nand/nand_base.c:3972: warning: cannot understand function prototype: 'const char * const nand_ecc_modes[] = '
>    drivers/mtd/nand/nand_bbt.c:1: warning: no structured comments found
> >> drivers/mtd/nand/nand_base.c:3972: warning: cannot understand function prototype: 'const char * const nand_ecc_modes[] = '
> 
> vim +3972 drivers/mtd/nand/nand_base.c
> 
>   3956					chip->jedec_params.model);
>   3957		else
>   3958			pr_info("%s %s\n", nand_manuf_ids[maf_idx].name,
>   3959					type->name);
>   3960	
>   3961		pr_info("%d MiB, %s, erase size: %d KiB, page size: %d, OOB size: %d\n",
>   3962			(int)(chip->chipsize >> 20), nand_is_slc(chip) ? "SLC" : "MLC",
>   3963			mtd->erasesize >> 10, mtd->writesize, mtd->oobsize);
>   3964		return type;
>   3965	}
>   3966	
>   3967	/**
>   3968	 * It maps 'enum nand_ecc_modes_t' found in include/linux/mtd/nand.h
>   3969	 * into the device tree binding of 'nand-ecc', so that MTD
>   3970	 * device driver can get nand ecc from device tree.
>   3971	 */

I'll remove this kerneldoc header to avoid this warning.

> > 3972	static const char * const nand_ecc_modes[] = {
>   3973		[NAND_ECC_NONE]		= "none",
>   3974		[NAND_ECC_SOFT]		= "soft",
>   3975		[NAND_ECC_HW]		= "hw",
>   3976		[NAND_ECC_HW_SYNDROME]	= "hw_syndrome",
>   3977		[NAND_ECC_HW_OOB_FIRST]	= "hw_oob_first",
>   3978		[NAND_ECC_SOFT_BCH]	= "soft_bch",
>   3979	};
>   3980	
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com