Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY

From: David Lechner
Date: Fri Apr 01 2016 - 12:02:30 EST


On 04/01/2016 09:45 AM, Bin Liu wrote:
+EXPORT_SYMBOL_GPL(da8xx_usb20_phy_set_mode);

Don't prefer export symbols from PHY driver. That'll create unnecessary
dependencies between the controller and the PHY.

Agreed.


I think it'll be better to create a new attribute and use it?

Another simpler option is to not support _set_mode() for DA8xx, and the
phy driver set the otgmode bit in probe() based on dr_mode of the
controller.

Regards,
-Bin.


This certainly works for my particular use case, however, Sergei Shtylyov, who wrote the da8xx musb glue layer originally, seemed to recall in his review of the patch series that this really is necessary for OTG mode to work properly.

By the way, there is v3 of this patch series already, although this patch is nearly the same.