Re: [RFC PATCH] sched/fair: call cpufreq hook in additional paths
From: Peter Zijlstra
Date: Fri Apr 01 2016 - 17:54:12 EST
On Fri, Apr 01, 2016 at 02:40:32PM -0700, Steve Muckle wrote:
> On 03/31/2016 02:14 AM, Peter Zijlstra wrote:
> > On Thu, Mar 31, 2016 at 09:59:51AM +0200, Peter Zijlstra wrote:
> >>> > > - passing an argument into attach_entity_load_avg() to indicate
> >>> > > whether calling the cpufreq hook is necessary
> >>> > >
> >>> > > Both of these are ugly in their own way but would avoid a runtime
> >>> > > cost. Opinions welcome.
> >> >
> >> > Lemme see what this would look like while I throw the below into the bit
> >> > bucket.
> > OK, so the below looks a lot more sane; and has the surprising benefit
> > of actually shrinking the text size..
> >
> > 43675 1226 24 44925 af7d defconfig-build/kernel/sched/fair.o.base
> > 43723 1226 24 44973 afad defconfig-build/kernel/sched/fair.o.patch
> > 43595 1226 24 44845 af2d defconfig-build/kernel/sched/fair.o.patch+
> >
> > ---
> > --- a/kernel/sched/fair.c
> > +++ b/kernel/sched/fair.c
>
> Cool, thanks. Shall I fold this into this patch and resend the series of
> 3? Or would you prefer to add this change separately?
I think I've got it folded into your third patch, I haven't published
the queue yet though; I'll try and sort through the stuff I have on
Monday or so.