Re: [PATCH v2] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver

From: Mark Brown
Date: Sat Apr 02 2016 - 12:34:43 EST


On Fri, Apr 01, 2016 at 04:21:17PM +0800, PC Liao wrote:

> +Optional properties:
> +- mediatek,audio-codec-dai-capture: audio codec dai on capture path
> + rt5645-aif1: Default setting. Connect rt5650 I2S1 for capture
> + rt5645-aif2: Connect rt5650 I2S2 for capture

No, this has exactly the same issue as the previous version. To repeat
what I said last time I would expect that the driver should just specify
the links between the DAIs. Look at how other devices reference DAIs.

Attachment: signature.asc
Description: PGP signature