Re: [PATCH 4/7] drivers/mfd: make max14577.c explicitly non-modular

[Paul Gortmaker]

[Re: [PATCH 4/7] drivers/mfd: make max14577.c explicitly non-modular] On 04/04/2016 (Mon 12:42) Krzysztof Kozlowski wrote:

> On 04.04.2016 06:24, Paul Gortmaker wrote:
> > The Kconfig currently controlling compilation of this code is:
> > 
> > mfd/Kconfig:config MFD_MAX14577
> > mfd/Kconfig:   bool "Maxim Semiconductor MAX14577/77836 MUIC + Charger Support"
> > 
> > ...meaning that it currently is not being built as a module by anyone.

[...]

> > ---
> >  drivers/mfd/max14577.c | 13 +------------
> >  1 file changed, 1 insertion(+), 12 deletions(-)
> 
> +Cc Javier,
> 
> In general I agree with the patchset except maybe here because it
> conflicts with Javier's work to make it a module:
> mfd: max14577: Use module_init() instead of subsys_initcall()
> http://www.spinics.net/lists/kernel/msg2213747.html

No problem, I'll shelf this one as well and assume it is on the
way to being tristate.

Thanks,
Paul.
--

> 
> Javier's patchset is however missing a tested-by tag so maybe this is
> why it was not merged.
> 
> Unfortunately I cannot provide testing because my current device with
> max14577/max77836 is dead and its recovery is not easy. Maybe I will get
> a proper device in a few weeks after going back to Poland.
> 
> My proposal would be to wait with this max14577 change a little bit.
> 
> Best regards,
> Krzysztof