Re: [PATCH 4/4] efi: A misc char interface to update EFI firmware

[Matt Fleming]

On Fri, 01 Apr, at 03:48:50AM, Bryan O'Donoghue wrote:
> On Thu, 2016-03-17 at 12:57 +0000, Matt Fleming wrote:
> > Tested with Intel Quark Galileo GEN1 platform.
> 
> + * If the capsule is successfully submitted to the firmware, any
> + * subsequent calls to efi_capsule_pending() will return true. @pages
> + * must not be released or modified if this function returns
> + * successfully.
> 
> The only minor nit here is that you can't actually test this on a
> Galileo GEN1 since there's a non-standard header required to update the
> firmware on that platform !
> 
> So I suggest dropping that particular comment in the git log, since you
> can't actually *do* that on a Galileo without doing something about the
> required CSH (Clanton Secure Header) prefixed to the standard Capsule
> header.
> 
> Otherwise.
> 
> Reviewed-by: Bryan O'Donoghue <pure.logic@xxxxxxxxxxxxxxxxx>

Thanks Bryan. I've updated the commit log and added your Reviewed-by.