Re: [PATCH] arm64/debug: Remove superfluous SMP function call
From: Sergei Shtylyov
Date: Tue Apr 05 2016 - 06:59:00 EST
Hello.
On 4/4/2016 1:42 PM, Anna-Maria Gleixner wrote:
Since commit 1cf4f629d9d2 "cpu/hotplug: Move online calls to
hotplugged cpu" it is ensured that callbacks of CPU_ONLINE and
scripts/checkpatch.pl now enforces commit citing certain style, yours
doesn't quite match it, also need parens around quotes enclosing the summary.
CPU_DOWN_PREPARE are processed on the hotplugged cpu. Due to this SMP
function calls are no longer required.
Replace smp_call_function_single() with a direct call to
clear_os_lock(). The function writes the OSLAR register to clear OS
locking. This does not require to be called with interrupts disabled,
therefore the smp_call_function_single() calling convention is not
preserved.
Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
Cc: Will Deacon <will.deacon@xxxxxxx>
Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxx
Signed-off-by: Anna-Maria Gleixner <anna-maria@xxxxxxxxxxxxx>
[...]
MBR, Sergei