Re: [PATCH 26/27] kernel/power/swap.c: use bio_get_base_vec()

[Ming Lei]

On Tue, Apr 5, 2016 at 8:56 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> I really don't like all these bio_get_base_vec uses.  The end_io
> handlers generall want to iterate over all pages in the bio, with
> a special case where all of them is the fixed number one.
>
> So What I think we'll need is a bio_for_each_page, and if there is
> any good justification for it as special version of the single
> page case.

I thought about that too, and bio_get_base_vec() can be thought as
the special version too, IMO.  Actually it is just about the name of
the helper, do you have a better name or other idea for such issue?

There are about ten such usages, as found in this patchset.


Thanks,
Ming Lei