Re: [PATCHv10 1/3] rdmacg: Added rdma cgroup controller
From: Parav Pandit
Date: Tue Apr 05 2016 - 10:14:58 EST
On Tue, Apr 5, 2016 at 7:07 AM, Tejun Heo <tj@xxxxxxxxxx> wrote:
> Just one more thing.
>
> On Tue, Apr 05, 2016 at 10:01:07AM -0400, Tejun Heo wrote:
> ...
>> > pool_info in spin lock context, made me allocate memory to get all
>> > values upfront through allocation.
>> > Now that the lock is going away, I can do what you have described above.
>
> So, this might be okay depending on the use case but it often becomes
> painful to require sleeping context for freeing resources. If you're
> certain that requiring sleeping context is okay for all paths, using a
> single mutex is fine but *usually* it isn't a great idea.
>
At present charge and uncharge are from sleeping context.
>
> --
> tejun