Re: [PATCH] iommu: change generic_device_group function

[Joerg Roedel]

On Fri, Mar 25, 2016 at 08:06:51PM +0800, cn_wyl2003@xxxxxxx wrote:
> From: yalin wang <yalin.wang2010@xxxxxxxxx>
> 
> change this function to return only iommu_group* pointer or
> PTR_ERR(), never return NULL when failed.
> The caller of this function only check IS_ERR() for its return value.
> 
> Signed-off-by: yalin wang <yalin.wang2010@xxxxxxxxx>

You are right, thanks for catching this. But please leave the
generic_device_group function in iommu.c. It is assigned to a function
pointer by drivers, so inlining it doesn't make sense anyway.


	Joerg