Re: [PATCH] fs: return EPERM on immutable inode

From: Dave Chinner
Date: Tue Apr 05 2016 - 16:44:38 EST


On Tue, Apr 05, 2016 at 09:28:10PM +0800, Eryu Guan wrote:
> In most cases, EPERM is returned on immutable inode, and there're only
> a few places returning EACCES. And EPERM looks more reasonable to me.
>
> So converting all EACCES to EPERM on immutable inode.
>
> Signed-off-by: Eryu Guan <guaneryu@xxxxxxxxx>
> ---
>
> I noticed this when running LTP on overlayfs, setxattr03 failed due to
> unexpected EACCES on immutable inode.

This should be in the commit message itself, rather than "EPERM
looks more reasonable".

Other than that, change seems fine to me.

Acked-by: Dave Chinner <dchinner@xxxxxxxxxx>
--
Dave Chinner
david@xxxxxxxxxxxxx