Re: [PATCH] libnvdimm, nfit: report multiple interface codes per-dimm

From: Johannes Thumshirn
Date: Wed Apr 06 2016 - 04:23:00 EST


On 2016-04-06 02:35, Dan Williams wrote:
Starting with ACPI 6.1 an NFIT table will report multiple 'NVDIMM
Control Region Structure' instances per-dimm, one for each supported
format interface. Report that code in the following format in sysfs:

nmemX/nfit/formats
nmemX/nfit/format
nmemX/nfit/format1
nmemX/nfit/format2
...
nmemX/nfit/formatN

Where format2 - formatN are theoretical as there are no known DIMMs with
support for more than two interface formats.

This layout is compatible with existing libndctl binaries that only
expect one code per-dimm as they will ignore nmemX/nfit/formats and
nmemX/nfit/formatN.

Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>

Looks OK to me
Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx>