Re: [PATCH v5 1/4] leds: core: add generic support for RGB Color LED's
From: Pavel Machek
Date: Wed Apr 06 2016 - 05:17:00 EST
Hi!
> >As I see it the current blinking support then would be one special case of a pattern.
> >As a consequence once having pattern support we might be able to switch users of blinking
> >to pattern and remove the blinking support.
>
> Let's split patterns related discussion into a separate thread.
> It would be best if it began with a patch.
Lets design userland interface first, then decide how to implement it
in the kernel. Patches are useless at this point.
And actually... without patterns, existing interface works just
fine. Even if you can't "atomically" write values to three different
files, operation is so fast that user will not see the intermediate
state, anyway. So solving the "atomic" issue without solving the rest
is pretty much useless.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html