Re: [PATCH] staging: comedi: das1800: remove unused variable

[Ian Abbott]

On 06/04/16 02:21, Hartley Sweeten wrote:
> On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote:
> > The variable unipolar was never used.
> >
> > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@xxxxxxxxxxxxxxx>
> > ---
> >
> > There may be a chance that reading from DAS1800_CONTROL_C is necessary
> > before reading from DAS1800_STATUS. If that is true then please discard
> > this patch.
>
> Actually the driver has a bug here.
>
> The analog input samples should  be munged if the inputs are configured for
> bipolar mode.
>
> I have a series almost ready that cleans up this driver and fixes the bug.

Hi Hartley, can the bug fix be placed at the top of your patch series? 
Thanks.

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx> )=-
-=(                          Web: http://www.mev.co.uk/  )=-