But you called it a device, so you can understand my confusion.It's not a device. It's just an encapsulation for parameters passed into+struct intel_mux_dev {This is a device, why not make it one? Don't just hold a reference.
+ struct device *dev;
+ char *extcon_name;
+ char *cable_name;
+ int (*cable_set_cb)(struct intel_mux_dev *mux);
+ int (*cable_unset_cb)(struct intel_mux_dev *mux);
+};
And do you really even hold that reference?
intel_usb_mux_register().
And why not make it a device? Why isn't this one? Hint, I really think
it should be...
It should be a device, as you are treating it like one :)And your api is horrid, think about what you want the "core" to do here,This isn't a layer or core. It doesn't create any new devices. It's actually
it should be the one creating the device and returning it to the caller,
not forcing the caller to somehow create it first and then pass it in.
some shared code which can be used by all Intel dual role port drivers.
I put it in a separated file because 1) this can avoid duplication; 2) this codeIt's a bit hard for other arches to be using something called "intel_"
could be used for any architectures as long as a USB port is shared by
two components and it needs an OS response when event triggers.
:(
Are there any other implementations which need an external mux
to swap the usb roles?