Re: [PATCH] staging: rtl8192u: remove blank lines after braces (opening)
From: Joe Perches
Date: Thu Apr 07 2016 - 14:12:12 EST
On Thu, 2016-04-07 at 21:06 +0300, Andy Shevchenko wrote:
> On Thu, Apr 7, 2016 at 9:04 PM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> > On Thu, 2016-04-07 at 20:59 +0300, Andy Shevchenko wrote:
> > > On Tue, Apr 5, 2016 at 7:07 PM, Nicholas Sim wrote:
> > > >
> > > > Remove unneeded blank lines appearing after opening braces as suggested
> > > > by checkpatch.pl
> > > >
> > > You have to combine this with the rest so called 'indentation' fixes,
> > > e.g. +- empty lines, tabs vs. spaces, etc.
> > Actually, patches that do single things like removing
> > undesired blank lines are easier to review if separate
> > from patches that change horizontal whitespace.
> >
> Okay, but I think you at least agree that +- empty lines can be easily combined.
Not really, but it's not important enough to me to care much
either way.