Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

From: David Howells
Date: Thu Apr 07 2016 - 16:47:26 EST


David Miller <davem@xxxxxxxxxxxxx> wrote:

> > Excellent only if I can get at it to find out why the something went wrong.
> > If it's lost because the machine panics, then it is worthless.
>
> If you're ok with these kenter things spewing into the logs with the
> current facility, you can run the function tracer and have it record
> into the logs all the time too.

They don't do that unless you enable them. And I can enable them individually
at compile time or by set at runtime.

> I don't see any argument which is appropriate for keeping this stuff
> around.

Sigh.

As I said to Joe: I don't want to deal with converting to using ftrace at the
moment whilst I'm towards the end of reworking the rewrite of the code. I
have a stack of patches that would need reworking yet again.

David