Re: [PATCH 1/2] localmodconfig: Fix parsing of Kconfig "source" statements
From: joeyli
Date: Fri Apr 08 2016 - 10:59:22 EST
On Sat, Apr 02, 2016 at 10:55:21AM -0700, Benjamin Poirier wrote:
> The parameter of Kconfig "source" statements does not need to be quoted.
> The current regex causes many kconfig files to be skipped and hence,
> dependencies to be missed.
>
> Also fix the whitespace repeat count.
>
> Signed-off-by: Benjamin Poirier <bpoirier@xxxxxxxx>
Tested-by: Lee, Chun-Yi <jlee@xxxxxxxx>
> ---
> scripts/kconfig/streamline_config.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/streamline_config.pl b/scripts/kconfig/streamline_config.pl
> index f3d3fb4..7036ae3 100755
> --- a/scripts/kconfig/streamline_config.pl
> +++ b/scripts/kconfig/streamline_config.pl
> @@ -188,7 +188,7 @@ sub read_kconfig {
> $cont = 0;
>
> # collect any Kconfig sources
> - if (/^source\s*"(.*)"/) {
> + if (/^source\s+"?([^"]+)/) {
> my $kconfig = $1;
> # prevent reading twice.
> if (!defined($read_kconfigs{$kconfig})) {
> --
> 2.7.2
Regards
Joey Lee