Re: [PATCH] lib: lz4: fixed zram with lz4 on big endian machines

From: Greg KH
Date: Fri Apr 08 2016 - 12:50:59 EST


On Fri, Apr 08, 2016 at 04:23:24PM +0100, Rui Salvaterra wrote:
> Based on Sergey's test patch [1], this fixes zram with lz4 compression on big endian cpus. Tested on ppc64 with no regression on x86_64.

Please wrap your text at 72 columns in a changelog comment.

>
> [1] http://marc.info/?l=linux-kernel&m=145994470805853&w=4
>
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Rui Salvaterra <rsalvaterra@xxxxxxxxx>

Please attribute Sergey here in the signed-off-by area with a
"Suggested-by:" type mark

> ---
> lib/lz4/lz4defs.h | 29 +++++++++++++++--------------
> 1 file changed, 15 insertions(+), 14 deletions(-)
>
> diff --git a/lib/lz4/lz4defs.h b/lib/lz4/lz4defs.h
> index abcecdc..a98c08c 100644
> --- a/lib/lz4/lz4defs.h
> +++ b/lib/lz4/lz4defs.h
> @@ -11,8 +11,7 @@
> /*
> * Detects 64 bits mode
> */
> -#if (defined(__x86_64__) || defined(__x86_64) || defined(__amd64__) \
> - || defined(__ppc64__) || defined(__LP64__))
> +#if defined(CONFIG_64BIT)

This patch seems to do two different things, clean up the #if tests, and
change the endian of some calls. Can you break this up into 2 different
patches?

thanks,

greg k-h